Skip to content

feat: derive Deserialize, Clone, PartialEq, Eq for MetadataPrelude #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

feat: derive Deserialize, Clone, PartialEq, Eq for MetadataPrelude #956

merged 1 commit into from
May 28, 2025

Conversation

DiscreteTom
Copy link
Contributor

✍️ Description of changes:
Derive Deserialize, Clone, PartialEq, Eq for MetadataPrelude. These traits are useful for 3rd party libs to use the struct.

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jlizen
Copy link
Contributor

jlizen commented May 28, 2025

@bnusunny do you see any blockers for this?

bnusunny
bnusunny approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnusunny bnusunny merged commit 1a7c696 into awslabs:main May 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnusunny bnusunny bnusunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DiscreteTom @jlizen @bnusunny